Uploaded image for project: 'Smack'
  1. Smack
  2. SMACK-362

smack throw NoSuchElementException if the muc#roominfo_subject has no values

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.2.2
    • Component/s: Core
    • Labels:
      None

      Description

      I reviewed this issue for Spark-1462 and it seems that its an error related to smack.
      If the subject is for that I reviewed this issue for Spark and it seems that its an error related to smack.

      Smack checks if there is a muc#roominfo_subject element but not, if that element has any values.
      This can cause NoSuchElementException in RoomInfo.java.

        Attachments

          Issue Links

            Activity

            Hide
            timjentz Tim Jentz added a comment -

            This patch should solve this problem by checking if the subject has any values.

            Show
            timjentz Tim Jentz added a comment - This patch should solve this problem by checking if the subject has any values.
            Hide
            timjentz Tim Jentz added a comment -

            Since i think the description field could cause the same problem like the subject field, i updated the patch to check the description values too.

            Show
            timjentz Tim Jentz added a comment - Since i think the description field could cause the same problem like the subject field, i updated the patch to check the description values too.
            Hide
            rcollier Robin Collier added a comment -

            Added modified version of patch. The patch returned "n/a" instead of "", which was what was being returned before. This has the potential for breaking existing code since any check for an empty string would fail.

            Show
            rcollier Robin Collier added a comment - Added modified version of patch. The patch returned "n/a" instead of "", which was what was being returned before. This has the potential for breaking existing code since any check for an empty string would fail.

              People

              • Assignee:
                rcollier Robin Collier
                Reporter:
                timjentz Tim Jentz
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: