Looks like it now works correctly.

I still get the error when trying to bookmark a persistent room.

commited:

r12571 = d4a5ecc2160d44654f3d31ad4a2c5a2c3a76b16b

Description:

-removed the filter added on a previous commit that was preventing for a temporary room to be added on the room browser list
(that filtering cannot be consistent - all queried rooms should show on the room browser, otherwise its confusing)
-when room configuration is changed, and marked as non persistent, the bookmark associated will automatically be removed (if any)
changes will take effect at next spark restart

What is noticed is that in Spark group chat room configuration dialog,
when I create a persistent room - if then I uncheck: List Room in Directory checkbox (the Persistent checkbox remains checked)
then in spark that room is reported as NOT persistent

The code: final RoomInfo roomInfo = MultiUserChat.getRoomInfo(SparkManager.getConnection(), roomJID);
persistent = roomInfo.isPersistent();

returns persistent = false.

If then I mark as checked the List Room in Directory checkbox, the code from above returns persistent true (Persistent checkbox always marked as checked - so the room is technically persistent - I went to Openfire Admin Console and that room was marked always as persistent)

so looks like a bug in SMACK...I think.

As a side note: I will remove my filtration that when a room is created temporary not to add it in the browser list - that is wrong: the: List Room in Directory option offers such behavior

This maybe related to some other bug. All my rooms show N/A in the Occupants column. This is due to some bug in the embedded database. It wasn't showing any rooms in the Conference browser. Then Wolf made a workaround to show N/A if there are errors in the database. Maybe that's why i can't bookmark persistent rooms now? The only thing to fix errors is to start with a fresh database which is not an option for most users.

I have updated my source code via SVN, builded it with Netbeans and launched on XP, then i tried to create a persistent room via Spark and Admin Console. Then i refreshed the room browser and tried to bookmark one of these rooms and got the error.