Broadcast message is not shown with bolded red font in the tab

Description

When general new messages arrive in Spark and there are multiple tabs open, unread tabs are shown with bold and red font until you click on that tab (emphasizes unread messages). But when broadcast messages arrive it doesn't mark it with bold red font and the new tab looks like it doesn't have unread messages.

Environment

None

Activity

Show:

wroot January 28, 2016 at 7:58 AM

Merged patch from Alexander https://github.com/igniterealtime/Spark/commit/238585bab1632aa3a7b4b6392fc86a50671dd3b6

Seems to be working until starts to appear.

wroot October 9, 2015 at 3:44 PM
Edited

What i was able to find out.

In src/java/org/jivesoftware/sparkimpl/plugin/alerts/BroadcastPlugin.java at 427 if i remove check for "room.getUnreadMessageCount() > 0" then a tab with broadcast message becomes red and bolded, but only until you bring chat window to the focus (while the tab itself is not in the focus).

It looks like 1) broadcast messages do not increase unread messages counter, 2) broadcast tab is getting the effect of selected tab even if you only bring chat window to focus

Same checks in src/java/org/jivesoftware/spark/decorator/DefaultTabHandler.java work fine for regular messages.

additionally BroadcastPlugin.java shouldn't use Color(red) for unread tab, but:
tab.setTitleColor((Color) UIManager.get("Chat.unreadMessageColor"));

Fixed

Priority

Assignee

Reporter

Affects versions

Fix versions

Created May 24, 2013 at 7:13 AM
Updated January 31, 2016 at 6:39 PM
Resolved January 28, 2016 at 7:58 AM