SparkPlug: extend the plugin mechanism, make it more powerful
(SPARK-1311)
[SPARK-1313] Enhance ability to overwrite spark properties values through plugin Created: 02/May/11 Updated: 28/Oct/20 Resolved: 14/Aug/11 |
|
Status: | Closed |
Project: | Spark |
Components: | None |
Affects versions: | None |
Fix versions: | 2.7.0 | Parent: | SparkPlug: extend the plugin mechanism, make it more powerful |
Type: | Sub-task | Priority: | Major |
Reporter: | Mircea Carasel | Assignee: | Mircea Carasel |
Resolution: | Fixed | Votes: | 0 |
Labels: | None | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original estimate: | Not Specified |
Attachments: | SPARK-1313.patch testPlugin.jar | ||||||||
Issue links: |
|
Description |
Define rule to permit plugins to overwrite spark properties values Spark defines values like: Login Page image, background, Application name etc in |
Comments |
Comment by Mircea Carasel [ 02/May/11 ] |
The attached patch contains: -improved Spark Resources management: SparkRes.java and Default.java When a property value is retrieved, first is looked in a specific plugin location. You simply add spark.properties and default.properties with keys/values you want overwritten by plugin NOTE: this patch needs SPARK-1312 Closed attached patch Please review |
Comment by Mircea Carasel [ 03/May/11 ] |
I am attaching a test plugin as an example how spark properties values can be overwritten I changed the application name into: My Spark APPLICATION_NAME = My Spark |
Comment by Mircea Carasel [ 10/May/11 ] |
The attached patch does not scale very well when many plugins are installed, some of the properties are not correctly overwritten in this schenario. I will post a new patch that better handles resource props overriding |
Comment by Mircea Carasel [ 10/May/11 ] |
New patch attached -load plugin resources into dedicated HashMaps at plugin loading phase |
Comment by Mircea Carasel [ 14/Aug/11 ] |
commited an improved version of the patch r12573 = 8b197eb26154943ea40c9e68346e55fb5d92a889 Description: -improved Spark Resources management: SparkRes.java, Default.java, Res.java, LocalPreferences.java PluginManager calls loadPluginResources() to load all plugin resources using the plugin' class loader You simply add spark.properties, default.properties, spark_i18n.properties (and language specific spark_i18n_xx.proeprties), |
Comment by Mircea Carasel [ 12/Sep/11 ] |
commited r12593 = 5154538af5f9667b329f2d8db5a474bbcd77f3bc -make Spark user personal directory configurable through plugin (create dedicated properties key/value pairs in default.properties) |
Comment by Walter Ebeling [ 24/Feb/13 ] |
Mass closing of resolved issues |